feat(datastore): Return nested data for belongsTo associations in datastore #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Overall, these changes LGTM! We just need to get the tests passing now. Currently the build is failing due to these checkstyle issues:
> Task :aws-datastore:checkstyle
--
800 | [ant:checkstyle] [ERROR] /codebuild/output/src659932793/src/github.com/aws-amplify/amplify-android/aws-datastore/src/main/java/com/amplifyframework/datastore/storage/sqlite/SQLiteStorageAdapter.java:817: First sentence of Javadoc is missing an ending period. [SummaryJavadoc]
801 | [ant:checkstyle] [ERROR] /codebuild/output/src659932793/src/github.com/aws-amplify/amplify-android/aws-datastore/src/main/java/com/amplifyframework/datastore/storage/sqlite/SQLiteStorageAdapter.java:817: First sentence should end with a period. [JavadocStyle]
802 | [ant:checkstyle] [ERROR] /codebuild/output/src659932793/src/github.com/aws-amplify/amplify-android/aws-datastore/src/main/java/com/amplifyframework/datastore/storage/sqlite/SQLiteStorageAdapter.java:829: Line is longer than 120 characters (found 126). [LineLength]
803 | [ant:checkstyle] [ERROR] /codebuild/output/src659932793/src/github.com/aws-amplify/amplify-android/aws-datastore/src/main/java/com/amplifyframework/datastore/storage/sqlite/SQLiteStorageAdapter.java:831: Line is longer than 120 characters (found 129). [LineLength]
804 |
805 | > Task :aws-datastore:checkstyle FAILED
…at/return-nested-data
richardmcclellan
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Looks great @Jordan-Nelson, thanks for adding this support!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws-amplify/amplify-flutter#642
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.